Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot delete file after requiring it on Windows in 9.0.0.0.rc1 #3055

Closed
jeremyevans opened this issue Jun 15, 2015 · 5 comments
Closed

Cannot delete file after requiring it on Windows in 9.0.0.0.rc1 #3055

jeremyevans opened this issue Jun 15, 2015 · 5 comments
Labels
JRuby 9000
Milestone
JRuby 9.0.0.0.rc2

Comments

@jeremyevans
Copy link
Contributor

Looks like this broke between pre1 and pre2:

D:\>C:\jruby-9.0.0.0.pre1\bin\jruby -e "File.open('a.rb', 'a'){}; require './a.rb'; File.delete('a.rb'); p 1"
1

D:\>C:\jruby-9.0.0.0.pre2\bin\jruby -e "File.open('a.rb', 'a'){}; require './a.rb'; File.delete('a.rb'); p 1"
Errno::EACCES: Permission denied - a.rb
  delete at org/jruby/RubyFile.java:1116
   <top> at -e:1

D:\>C:\jruby-9.0.0.0.rc1\bin\jruby -e "File.open('a.rb', 'a'){}; require './a.rb'; File.delete('a.rb'); p 1"
Errno::EACCES: Permission denied - a.rb
  delete at org/jruby/RubyFile.java:1116
   <top> at -e:1

It doesn't matter if the a.rb file already exists or if the process creates it, trying to delete it after requiring it raises the error.

Found by running Sequel's specs.

I didn't test on a *nix, but it's unlikely to be a problem there as *nix allows deletion of files that are in use.
@djberg96
Copy link
Contributor

No problem on Windows 8 with MRI:

PS C:\Users\Daniel> ruby -v
ruby 2.0.0p645 (2015-04-13) [i386-mingw32]

PS C:\Users\Daniel> ruby -e "File.open('a.rb', 'a'){}; require './a.rb'; File.delete('a.rb'); p 1"
1

I don't know the implemenation details of require, but I wouldn't think it would retain a handle to the file once it was loaded.

@enebo enebo added this to the JRuby 9.0.0.0.rc2 milestone Jun 16, 2015
@enebo
Copy link
Member

enebo commented Jun 16, 2015

Strange. Lexer changed between those two but it should not retain a reference to anything which would retain a HANDLE. Perhaps some IO fixes are hanging onto a handle in an IO table somewhere? We do use IO.gets for a small amount of parsing now so it could ??? who knows...just brainstorming but thanks for heads up.

@djberg96
Copy link
Contributor

@enebo can you point us to the IO.gets changes you're referring to?

@enebo
Copy link
Member

enebo commented Jun 18, 2015

@djberg96 org.jruby.lexer.GetsLexerSource

@djberg96
Copy link
Contributor

I tried adding some explicit close calls in there, but then it complained about a closed stream, so I must have done it too soon.

@enebo enebo closed this as completed in de65120 Jun 30, 2015
@enebo enebo mentioned this issue Jul 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JRuby 9000
Projects
None yet
Milestone
JRuby 9.0.0.0.rc2
Development

No branches or pull requests
3 participants
@jeremyevans @enebo @djberg96