Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Truffle] Testing JRuby against TruffleTCK to verify consistency with… #3063

Merged
merged 1 commit into from
Jun 18, 2015
Merged

[Truffle] Testing JRuby against TruffleTCK to verify consistency with… #3063

merged 1 commit into from
Jun 18, 2015
+82 −0

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented Jun 18, 2015

… other languages.

chrisseaton added a commit that referenced this pull request Jun 18, 2015
@chrisseaton
Merge pull request #3063 from jtulach/TruffleTCK
3940be6 
[Truffle] Testing JRuby against TruffleTCK to verify consistency with…
@chrisseaton chrisseaton merged commit 3940be6 into jruby:truffle-head Jun 18, 2015
@chrisseaton chrisseaton self-assigned this Jun 18, 2015
@chrisseaton chrisseaton added this to the truffle-dev milestone Jun 18, 2015
@chrisseaton
Copy link
Contributor

I don't think this is actually run by anything yet - we'll need to set up various CI systems to run them. What command did you use?

@jtulach
Copy link
Contributor Author

jtulach commented Jun 19, 2015

When I do:
$ mvn install
the RubyTckTest gets executed as part of the build

mkristian
mkristian reviewed Jun 19, 2015
View reviewed changes
truffle/pom.xml
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
</dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make pom changes in pom.rb - the pom.xml are generated (and will get a big warning soon - waiting for a release for this)

@jtulach
Copy link
Contributor Author

jtulach commented Jun 19, 2015

The changes are likely to be

$ git diff
diff --git a/truffle/pom.rb b/truffle/pom.rb
index e6f3e6c..a5e0df4 100644
--- a/truffle/pom.rb
+++ b/truffle/pom.rb
@@ -18,6 +18,8 @@ project 'JRuby Truffle' do
   truffle_version = '0.8-ef8c90391f1ec21bcfb6d5c6fb39757b860d4973-SNAPSHOT'
   jar 'com.oracle:truffle:' + truffle_version
   jar 'com.oracle:truffle-dsl-processor:' + truffle_version, :scope => 'provided'
+  jar 'com.oracle:truffle-tck:' + truffle_version, :scope => 'test'
+  jar 'junit:junit', :scope => 'test'

but I am not sure how to verify that. My build seems to be using pom.xml all the time.

@mkristian
Copy link
Member

use mvn-3.3.x then it will pick the pom.rb over pom.xml. and there is mvnw in the root directory which is basically mvn-3.3.3

mvn-3.2.x or older will pick the pom.xml, like IDEs, etc

@eregon
Copy link
Member

eregon commented Jun 19, 2015

What is "TruffleTCK" ?

@chrisseaton
Copy link
Contributor

http://mail.openjdk.java.net/pipermail/graal-dev/2015-June/003233.html

@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisseaton chrisseaton

Labels
None yet
Projects
None yet
Milestone
Non-Release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jtulach @chrisseaton @mkristian @eregon @enebo