Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] is_a?: add cached fast path and TypeError #3047

Merged
merged 1 commit into from
Jun 18, 2015

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Jun 15, 2015

No description provided.

@pitr-ch pitr-ch self-assigned this Jun 15, 2015
@pitr-ch pitr-ch added this to the truffle-dev milestone Jun 15, 2015
}

protected int getCacheLimit() {
return LookupConstantNode.getCacheLimit();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is better to reference the original property (= inline the code). I think these getCacheLimit() should probably be all protected.

chrisseaton added a commit that referenced this pull request Jun 18, 2015
[Truffle] is_a?: add cached fast path and TypeError
@chrisseaton chrisseaton merged commit ba4a334 into jruby:master Jun 18, 2015
@Specialization
public boolean isA(Object self, RubyModule rubyClass) {
public boolean isAUncached(VirtualFrame frame, Object self, RubyModule module) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue, but this probably should be isAUncached.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm losing my mind. I swear I read isaUncached and I checked a few times before commenting. Sorry for the noise.

@pitr-ch pitr-ch deleted the is_a branch July 21, 2016 09:17
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants