[Truffle] is_a?: add cached fast path and TypeError #3047
Merged
+39
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| protected int getCacheLimit() { | ||
| return LookupConstantNode.getCacheLimit(); |
There was a problem hiding this comment.
Maybe it is better to reference the original property (= inline the code). I think these getCacheLimit() should probably be all protected.
chrisseaton
added a commit
that referenced
this pull request
Jun 18, 2015
[Truffle] is_a?: add cached fast path and TypeError
| @Specialization | ||
| public boolean isA(Object self, RubyModule rubyClass) { | ||
| public boolean isAUncached(VirtualFrame frame, Object self, RubyModule module) { |
There was a problem hiding this comment.
Minor issue, but this probably should be isAUncached.
There was a problem hiding this comment.
I guess I'm losing my mind. I swear I read isaUncached and I checked a few times before commenting. Sorry for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.