Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 53c1ece6f023
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9f0085a78d4a
Choose a head ref
  • 4 commits
  • 10 files changed
  • 1 contributor

Commits on Jun 15, 2015

  1. [Truffle] Exclude ARGF specs as the Rubinius implementation is not co… 

    …mpliant with them for now
    @eregon
    eregon committed Jun 15, 2015
    Copy the full SHA
    6d0b3a7 View commit details

  2. Squashed 'spec/ruby/' changes from 1ac2212..d128ccf 

    d128ccf Fix leak and error in File.open(fd) spec

git-subtree-dir: spec/ruby
git-subtree-split: d128ccf4fb146322d2fe0e457894d314bc1621ad
    @eregon
    eregon committed Jun 15, 2015
    Copy the full SHA
    744cbf6 View commit details

  3. Merge commit '744cbf653db01db1251ef15c317595ed2041496d'

    @eregon
    eregon committed Jun 15, 2015
    Copy the full SHA
    f53372e View commit details

  4. [Truffle] Add tags for failing specs.

    @eregon
    eregon committed Jun 15, 2015
    Copy the full SHA
    9f0085a View commit details
7 changes: 4 additions & 3 deletions spec/ruby/core/file/open_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -147,12 +147,13 @@
it "opens the file when call with fd" do
fh_orig = File.open(@file)
begin
@fh = File.open(fh_orig.fileno)
(@fh.autoclose = false) rescue nil
@fh.should be_kind_of(File)
fh = File.open(fh_orig.fileno)
fh.should be_kind_of(File)
File.exist?(@file).should == true
ensure
fh_orig.close
# Will raise but we need it to set the internal close flag
fh.close rescue nil
end
end

1 change: 1 addition & 0 deletions spec/truffle/tags/core/argf/lineno_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
slow:ARGF.lineno aliases to $.
1 change: 1 addition & 0 deletions spec/truffle/tags/core/argf/rewind_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
slow:ARGF.rewind resets ARGF.lineno to 0
4 changes: 4 additions & 0 deletions spec/truffle/tags/core/argf/set_encoding_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
slow:ARGF.set_encoding sets the external encoding when passed an encoding instance
slow:ARGF.set_encoding sets the external encoding when passed an encoding name
slow:ARGF.set_encoding sets the external, internal encoding when passed two encoding instances
slow:ARGF.set_encoding sets the external, internal encoding when passed 'ext:int' String
1 change: 1 addition & 0 deletions spec/truffle/tags/core/regexp/compile_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
fails:Regexp.compile given a String uses ASCII_8BIT encoding if third argument is 'n' or 'none' (case insensitive) and non-ascii characters
fails:Regexp.compile given a Regexp sets the encoding to source String's encoding if the Regexp literal has the 'n' option and the source String is not ASCII only
1 change: 1 addition & 0 deletions spec/truffle/tags/core/regexp/new_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
fails:Regexp.new given a String uses ASCII_8BIT encoding if third argument is 'n' or 'none' (case insensitive) and non-ascii characters
fails:Regexp.new given a Regexp sets the encoding to source String's encoding if the Regexp literal has the 'n' option and the source String is not ASCII only
1 change: 1 addition & 0 deletions spec/truffle/tags/library/open3/popen3_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
fails:Open3.popen3 executes a process with a pipe to read stdout
fails:Open3.popen3 executes a process with a pipe to read stderr
fails:Open3.popen3 executes a process with a pipe to write stdin
fails:Open3.popen3 returns in, out, err and a thread waiting the process
1 change: 1 addition & 0 deletions spec/truffle/tags/library/tempfile/close_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -3,3 +3,4 @@ fails:Tempfile#close when passed [true] closes self
fails:Tempfile#close when passed [true] unlinks self
fails:Tempfile#close! closes self
fails:Tempfile#close! unlinks self
fails:Tempfile#close when passed no argument or [false] does not unlink self
1 change: 1 addition & 0 deletions spec/truffle/tags/library/tempfile/initialize_tags.txt
View file
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
fails:Tempfile#initialize opens a new tempfile with the passed name in the passed directory
fails:Tempfile#initialize sets the permisssions on the tempfile to 0600
fails:Tempfile#initialize accepts encoding options
3 changes: 3 additions & 0 deletions spec/truffle/truffle.mspec
View file
Original file line number Diff line number Diff line change
@@ -14,6 +14,9 @@ class MSpecScript
core = [
"spec/ruby/core",

# Specs are incompatible with the current implementation
"^spec/ruby/core/argf",

# Can't load these - so tags aren't enough to exclude them. The problem is
# either fixtures or syntax. Some of them are probably easy fixes.