Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] BigDecimal fixes #3048

Merged
merged 6 commits into from
Jun 18, 2015
Merged

[Truffle] BigDecimal fixes #3048

merged 6 commits into from
Jun 18, 2015

Conversation

pitr-ch
Copy link
Member

@pitr-ch pitr-ch commented Jun 15, 2015

No description provided.

pitr-ch added 4 commits June 15, 2015 11:35
with neverPartOfCompilation and UnsupportedOperationExceptions
* More shapes does not bring more benefits since the dynamic object storage uses
  3 fields anyway.
* When new Array creation will be replaced with nodes it can be easily found by
  the createArray usages, no need for todos.
@pitr-ch pitr-ch self-assigned this Jun 15, 2015
@pitr-ch pitr-ch added this to the truffle-dev milestone Jun 15, 2015
@Child private ToIntNode signToInt;
@Child private ToIntNode exponentToInt;
@Child private IntegerCastNode signIntegerCast;
@CoreMethod(names = "unscaled")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this method is not present in normal Ruby, it should be private (if possible or protected otherwise) and annotated with @RubiniusOnly (not so well named for this).

chrisseaton added a commit that referenced this pull request Jun 18, 2015
[Truffle] BigDecimal fixes
@chrisseaton chrisseaton merged commit 8c790a3 into jruby:master Jun 18, 2015
@enebo enebo added this to the Non-Release milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants