Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for ipfs add -t #1390

Closed
wants to merge 1 commit into from
Closed

Conversation

dylanPowers
Copy link
Member

A test was missing for ipfs add -t and should have been included in #1379

@jbenet
Copy link
Member

jbenet commented Jun 18, 2015

thanks @dylanPowers -- but we should be testing that -t actually does what it says it will do, not just that the option works in the base case...

We should be testing that the output of adding file is really a trickledag. This means adding a large enough file and testing the chunking to confirm it has certain properties. if you don't want to go through testing this whole thing now, I'll just remove -t until someone does.

@whyrusleeping
Copy link
Member

would be a lot easier to test if we had an option for blocksize

@rht
Copy link
Contributor

rht commented Jun 19, 2015

Reminder to update the sharness testing "Mendeleev" table.

@dylanPowers dylanPowers force-pushed the use-trickle-dag branch 2 times, most recently from da4408e to 9f68fcd Compare June 19, 2015 20:26
License: MIT
Signed-off-by: Dylan Powers <dylan.kyle.powers@gmail.com>
@dylanPowers
Copy link
Member Author

Updated with a test to verify that the object has trickle dag properties


test_links_in_trickle_dag() {
local LINKS="$(ipfs object links $1)"
local i="0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure but i think local is a bashism. we're restricted to Bourne Shell (sh) for portability.

@rht rht mentioned this pull request Oct 3, 2015
@whyrusleeping
Copy link
Member

closing, old PR cleanup time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants