Fix part of 1823 #1824
Merged
Fix part of 1823 #1824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could just just make the |
|
Yes, sounds like a refactor that gives us value :-) |
This was referenced Jun 27, 2015
|
Guess we can merge for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Nikola initialize LocaleBorg when called without a config file, which is needed to use the default config from importers and should have no bad side effects.
As a result of this, if you import using wordpress like this:
The config file will be loaded. However, there is still a case where this is broken:
In that case, the config will NOT be loaded, which means it will do bad things. So #1823 is not completely fixed by this.