Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Travis build should be split in a "build jruby" phase and the rest #3050

Closed
eregon opened this issue Jun 15, 2015 · 7 comments
Closed

The Travis build should be split in a "build jruby" phase and the rest #3050

eregon opened this issue Jun 15, 2015 · 7 comments
Milestone

Comments

@eregon
Copy link
Member

eregon commented Jun 15, 2015

Current travis configuration has a travis_retry around the whole maven command, which makes some failing builds last 3 times as long as they should.

Also, if building jruby fails, there is no much point in running the tests afterwards.
Should ./mnvw -Pbootstrap install be in the install or before_script section?

@headius
Copy link
Member

headius commented Jun 15, 2015

I originally added travis_retry around entire builds because maven dependency fetching was failing intermittently. If maven builds (the actual build part) have stabilized, it would be reasonable to reduce the scope of travis_retry.

@mkristian
Copy link
Member

in other projects I do a mvn validate for the travis install script. maybe jruby could do a mvn install which basically just downloads and compiles the main parts (core + truffle + lib)

@headius
Copy link
Member

headius commented Jun 15, 2015

I think we should do travis_retry just around the build itself and remove the test run from being retried. If there's flaky tests or specs we should address them or mask them.

@eregon
Copy link
Member Author

eregon commented Jun 16, 2015

@mkristian Could you try to move the build in install:?
I would do it myself but I am not sure what's -Dinvoker.skip=false is about or what kind of cleaning is desirable.

@mkristian
Copy link
Member

will find some time tomorrow - there are other little build issue pending

On Tue, Jun 16, 2015 at 2:11 PM, Benoit Daloze notifications@github.com
wrote:

@mkristian https://github.com/mkristian Could you try to move the build
in install:?
I would do it myself but I am not sure what's -Dinvoker.skip=false is
about or what kind of cleaning is desirable.


Reply to this email directly or view it on GitHub
#3050 (comment).

@mkristian
Copy link
Member

it looks like those "extended" maven tests crash the VM once in a while. the old retry did hide this

@eregon
Copy link
Member Author

eregon commented Jun 18, 2015

@mkristian Thanks!

@enebo enebo added this to the Non-Release milestone Jul 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants