ISubstanceDescriptor API #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated the package - added missing class JavaDoc - fixed method JavaDoc that still pointed to IAtomContainer
|
Pull most in other request - add the lit ref one now. Note you can overwrite a pullrequest by pushing to the same branch. |
|
The patches were actually different... I did not overwrite the branch, because I have no clue what would happen to all the comments... and I did not want to loose those. |
|
John, the other patches had to be applied... I cleaned up stuff there... :( Can you please revert those and apply these? |
|
So is it just this pull request substancedescriptor3 that needs to be applied I can ignore the other two? |
|
Okay from what I can tell the first two are still okay? |
|
I think I changed at least one of them... should I check? |
|
OK, yes, confirmed: the first two patches are identical. John, you were right! |
|
Okay fixed now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please find here the pull request around further substance development. This PR is about the ISubstanceDescriptor API with one example descriptor. If the code is in order, I will backport more descriptors from NanoJava.