Fixed return value for Rubinius::Mirror::Range#step_float_iterations_… #3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -17,6 +17,8 @@ def step_float_iterations_size(first, last, step_size) | |||
| else | |||
| iterations = ((last - first) / step_size + err).floor + 1 | |||
| end | |||
|
|
|||
| iterations | |||
There was a problem hiding this comment.
Shouldn't the return value of the if excl block above already return this?
There was a problem hiding this comment.
If the if modifier is false, the result of the expression is nil.
There was a problem hiding this comment.
Alternatively, this could be pushed inside the if block. The issue only affects the excl case.
yorickpeterse
pushed a commit
that referenced
this pull request
Jun 22, 2015
Fixed return value for Rubinius::Mirror::Range#step_float_iterations_…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…size.