importer/importer: Check for modes that aren't regular files or directories

wking · wking · commit 9f464bb6009e · 2015-06-21T06:45:57.000-07:00
For example, we want to crash if we hit a named pipe, not block
forever trying to read from it.

License: MIT
Signed-off-by: W. Trevor King &lt;wking@tremily.us&gt;
diff --git a/importer/importer.go b/importer/importer.go
@@ -30,6 +30,10 @@ func BuildDagFromFile(fpath string, ds dag.DAGService, mp pin.ManualPinner) (*da
 		return nil, fmt.Errorf("`%s` is a directory", fpath)
 	}
 
+	if !stat.IsRegular() {
+		return nil, fmt.Errorf("`%s` is neither a directory nor a file", fpath)
+	}
+
 	f, err := os.Open(fpath)
 	if err != nil {
 		return nil, err
