Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: e7c84f82c730
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: d38e865fce93
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jun 17, 2015

  1. timers: fix timeout when added in timer's callback

    When a timer is added in another timer's callback, its underlying timer
    handle will be started with a timeout that is actually incorrect.
    
    The reason is that  the value that represents the current time is not
    updated between the time the original callback is called and the time
    the added timer is processed by timers.listOnTimeout. That leads the
    logic in timers.listOnTimeout to do an incorrect computation that makes
    the added timer fire with a timeout of scheduledTimeout +
    timeSpentInCallback.
    
    This change fixes that and make timers scheduled within other timers'
    callbacks fire as expected.
    
    Fixes #9333 and #15447.
    
    PR: #17203
    PR-URL: #17203
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    Julien Gilli committed Jun 17, 2015
    5
    Copy the full SHA
    d38e865 View commit details
    Browse the repository at this point in the history