Add test that should pass... but does not :( #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this connect to a ticket? |
|
@awoods I'd like to confirm whether the statement in your PR is valid or not. When I change the underlying check logic (which did have a bug because it was counting on WHERE appearing after INSERT) and pass the statement as OK, I get an exception from Jena: com.hp.hpl.jena.query.QueryParseException: Encountered " <INSERT_DATA> "INSERT DATA "" at line 1, column 88. |
|
I am checking it now, but in the meantime you can run the migration-utils against your original PR to see the error. If you enable TRACE on migration-utils, you will see the exact sparql-update request that fails. |
|
Closing this PR in favor of an updated PR to @osmandin's 1409 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should not be merged into master. It should be incorporated (along with associated functional code) into PR-811.
An integration test on migration-utils revealed that PR-811 introduced an error:
http://jenkins.fcrepo.org/job/migration-utils/org.fcrepo.migration$migration-utils/115/testReport/junit/org.fcrepo.migration.handlers/BasicObjectVersionHandlerIT/org_fcrepo_migration_handlers_BasicObjectVersionHandlerIT/
PR-811 has been reverted from the master branch:
50a04b5
Rework of the following ticket is required: https://jira.duraspace.org/browse/FCREPO-1409