Mimic MRI's openssl when jopenssl require fails. #2894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some libraries (such as RubyGems) rescues openssl load errors and adjusts their behavior depending if the openssl is properly required. However, prior this commit, require 'openssl' succeeded just fine, but the subsequent requires failed, which makes RubyGems (and similar) to fail unexpectedly.
|
that this file 'openssl.rb' is in the jruby repo is probably not right. investigating . . . |
mkristian
added a commit
that referenced
this pull request
Apr 30, 2015
|
as I thought any change in this file will be overwritten by the one we import during the build from jruby-openssl.gem |
|
@voxik so any change in jruby-openssl will reflect on jruby. so next jruby-openssl version might have your patch. |
|
Perfect, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries (such as RubyGems [1]) rescues openssl load errors and
adjusts their behavior depending if the openssl is properly required.
However, prior this commit, require 'openssl' succeeded just fine, but
the subsequent requires failed, which makes RubyGems (and similar) to
fail unexpectedly.
[1] https://github.com/rubygems/rubygems/blob/master/lib/rubygems/security.rb#L14