Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept search results sometimes link to incorrect concepts - TRUNK-3961 #274

Merged
merged 1 commit into from Apr 17, 2013
Merged

Concept search results sometimes link to incorrect concepts - TRUNK-3961 #274

merged 1 commit into from Apr 17, 2013

Conversation

wluyima
Copy link
Member

@wluyima wluyima commented Apr 16, 2013

bufferedData = data[x];
bufferedRows.push(self._buildRow(bufferedData));
//add the data to the results list
self._results.push(bufferedData);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever is reviewing the code, if you are wondering what's going on here, the problem was line 1135 above in red, it was adding the returned hits to the cache of hits for an a given ajax call instead of waiting to do it when pulling the results from the 'buffer' where they are temporarily stored as we wait for earlier ajax calls to return if the ajax requests are being sent out in parallel, it is this way so that they are added to the datatable in the order the ajax calls were sent out to maintain the order in which they were pulled from the DB

@wluyima wluyima merged commit 08a949e into openmrs:master Apr 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant