Fix for issue 2896 on master : Symbol#inspect with utf8 encode string #2899
+23
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enebo
added a commit
that referenced
this pull request
May 1, 2015
Fix for issue 2896 on master : Symbol#inspect with utf8 encode string
|
@k77ch7 I wondered about this little snippet: !(c < 128))I would have wrote it as c >= 128 but it is fine this way as well. |
|
I applied this to jruby-1_7 as well...thanks again! |
|
I agree with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #2896 on master and closes #2713.
This patch is partial ports of the MRI rb_str_symname_p and rb_enc_symname_p.
Please review, @enebo. If this patch is OK, I also hope that this patch is applied to 1_7 branch.
Thanks!