Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: opal/opal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7e2aa427e99f
Choose a base ref
...
head repository: opal/opal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 62df841d04a8
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on May 5, 2015

  1. Move TOLERANCE = 0.00004 to spec/spec_helper to pass specs in Chrom… 

    …e too
    @vais
    vais committed May 5, 2015
    Copy the full SHA
    474647c View commit details

  2. Updated comment about TOLERANCE to include Google Chrome/V8

    @vais
    vais committed May 5, 2015
    Copy the full SHA
    1148500 View commit details

Commits on May 7, 2015

  1. Merge pull request #834 from vais/tolerance 

    Move `TOLERANCE = 0.00004` to spec/spec_helper so specs can pass in Chrome too
    @elia
    elia committed May 7, 2015
    Copy the full SHA
    62df841 View commit details
Showing with 4 additions and 2 deletions.
  1. +4 −0 spec/spec_helper.rb
  2. +0 −2 tasks/testing.rake
4 changes: 4 additions & 0 deletions spec/spec_helper.rb
View file
Original file line number Diff line number Diff line change
@@ -9,6 +9,10 @@
require 'math'
require 'encoding'

# Node v0.12 as well as Google Chrome/V8 42.0.2311.135 (64-bit)
# showed to need more tolerance (rubyspec default is 0.00003)
TOLERANCE = 0.00004

ENV['MSPEC_RUNNER'] = true

module Kernel
2 changes: 0 additions & 2 deletions tasks/testing.rake
View file
Original file line number Diff line number Diff line change
@@ -51,8 +51,6 @@ task :mspec_node do
mkdir_p File.dirname(filename)
enter_benchmarking_mode = ENV['BM'] && "OSpecRunner.main.bm!(#{Integer(ENV['BM'])})"
File.write filename, <<-RUBY
# Node v0.12 showed to need more tolerance, rubyspec default is 0.00003
TOLERANCE = 0.00004
require 'spec_helper'
#{enter_benchmarking_mode}
#{requires.join("\n ")}