Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate web modules #20

Closed
wants to merge 3 commits into from
Closed

Conversation

awoods
Copy link

@awoods awoods commented May 7, 2015

@acoburn
Copy link
Contributor

acoburn commented May 7, 2015

This looks good to me. Tested with several different profile combinations. We do want to be careful about the possibility that different camel routes will want to use different input.stream values, but in that case, someone can make different builds of this web app (if that is the case, they most certainly would already know what they're doing).

I have another meeting right now, but can merge this afterwards

@acoburn
Copy link
Contributor

acoburn commented May 7, 2015

@awoods before merging, can you update the base README file, updating references to audit-triplestore (should be fcrepo-audit-triplestore) and audit-triplestore-web (now part of the fcrepo-camel-webapp module)

@awoods
Copy link
Author

awoods commented May 7, 2015

Thanks, @acoburn. I will update the README. As for the input.stream, I assume we would want to use separate variables if different modules want different values.

@acoburn
Copy link
Contributor

acoburn commented May 7, 2015

@awoods in the trivial case (i.e. most cases) the input.stream value will be the same. As part of the "Add indexing endpoints" ticket, we'll need to have an auxiliary input value for the two indexing modules (but not the audit stream). For now, we should leave it as it is.

@acoburn
Copy link
Contributor

acoburn commented May 7, 2015

@awoods I'm going to merge this now and we can put the README updates in a separate PR

@acoburn
Copy link
Contributor

acoburn commented May 7, 2015

Resolved via 3b012c7

@acoburn acoburn closed this May 7, 2015
@awoods awoods deleted the fcrepo-1523 branch May 7, 2015 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants