[Truffle] Add EINVAL for negative File.truncate length

jruby · May 7, 2015 · dc1de58 · dc1de58 · nirvdrum · May 7, 2015
1 parent 15863ec
commit dc1de58
Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/spec/truffle/tags/core/file/truncate_tags.txt b/spec/truffle/tags/core/file/truncate_tags.txt
@@ -1,2 +1 @@
-fails:File.truncate raises an Errno::EINVAL if the length argument is not valid
 fails:File#truncate raises an IOError if file is closed
diff --git a/truffle/src/main/java/org/jruby/truffle/nodes/rubinius/IOPrimitiveNodes.java b/truffle/src/main/java/org/jruby/truffle/nodes/rubinius/IOPrimitiveNodes.java
@@ -122,6 +122,10 @@ public int truncate(RubyString path, int length) {
 
         @Specialization
         public int truncate(RubyString path, long length) {
+            if (length < 0) {
+                CompilerDirectives.transferToInterpreter();
+                throw new RaiseException(getContext().getCoreLibrary().invalidArgumentError(Long.toString(length), this));
+            }
             final String pathString = RubyEncoding.decodeUTF8(path.getByteList().getUnsafeBytes(), path.getByteList().getBegin(), path.getByteList().getRealSize());
             return posix().truncate(pathString, length);
         }
Original file line number	Diff line number	Diff line change
		@@ -1,2 +1 @@
		fails:File.truncate raises an Errno::EINVAL if the length argument is not valid
		fails:File#truncate raises an IOError if file is closed