Skip to content

Commit

Permalink
Showing 2 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -83,7 +83,6 @@ public Object coerceBasicObject(VirtualFrame frame, RubyBasicObject object) {
return coerceObject(frame, object);
}

@CompilerDirectives.TruffleBoundary
private Object coerceObject(VirtualFrame frame, Object object) {
if (toIntNode == null) {
CompilerDirectives.transferToInterpreter();
@@ -97,9 +96,7 @@ private Object coerceObject(VirtualFrame frame, Object object) {
} catch (RaiseException e) {
if (e.getRubyException().getLogicalClass() == getContext().getCoreLibrary().getNoMethodErrorClass()) {
CompilerDirectives.transferToInterpreter();

throw new RaiseException(
getContext().getCoreLibrary().typeErrorNoImplicitConversion(object, "Integer", this));
throw new RaiseException(getContext().getCoreLibrary().typeErrorNoImplicitConversion(object, "Integer", this));
} else {
throw e;
}
Original file line number Diff line number Diff line change
@@ -899,8 +899,9 @@ public Object deleteBang(VirtualFrame frame, RubyString string, Object... otherS
return deleteBangSlow(frame, string, otherStrings);
}

@CompilerDirectives.TruffleBoundary
private Object deleteBangSlow(VirtualFrame frame, RubyString string, Object... args) {
notDesignedForCompilation();

This comment has been minimized.

Copy link
@nirvdrum

nirvdrum May 3, 2015

Contributor

I think this is supposed to just be a transfer now, per 9de830f#commitcomment-11000453

This comment has been minimized.

Copy link
@chrisseaton

chrisseaton May 3, 2015

Contributor

Ideally we should refactor it so that it can compile normally - some of it might need to go into a helper method that is TruffleBoundary for example. If that isn't practical at the moment then a transfer is best. Transfer show up well in the tracing tools that we have.


RubyString[] otherStrings = new RubyString[args.length];

for (int i = 0; i < args.length; i++) {

0 comments on commit ef5da87

Please sign in to comment.