Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase iptb test stability #1194

Merged
merged 1 commit into from
May 5, 2015
Merged

increase iptb test stability #1194

merged 1 commit into from
May 5, 2015
+90 −22

Conversation

whyrusleeping
Copy link
Member

This moves each iptb test to its own port range and also ensures that daemons are fully bootstrapped if the -wait option is specified to prevent the 'no peers in routing table' errors we were seeing.

@whyrusleeping whyrusleeping added status/in-progress In progress kind/bug A bug in existing code (including security flaws) kind/test Testing work labels May 4, 2015
@jbenet
Copy link
Member

jbenet commented May 4, 2015

failed to vendor 1/100.

(when this counter reaches 100/100, we stop everything, write a new tool, and move off godeps for good).

@whyrusleeping
Copy link
Member Author

@jbenet can i just commit --amend and force push this same thing 100 times to increase the counter?

@jbenet
Copy link
Member

jbenet commented May 4, 2015

@whyrusleeping no, once per independent time. it's like a deadline. we can just write thins earlier and be done-- i just am sick of godeps crap.

@whyrusleeping
Copy link
Member Author

@jbenet do you know how to fix this?

@whyrusleeping
Copy link
Member Author

Yeah, no idea how to work godep. i ran godep update github.com/whyrusleeping/iptb and nothing changed. And then i tried godep save github.com/whyrusleeping/iptb and it deleted a whole bunch of packages (but not all of them i dont think, just a bunch)

@whyrusleeping
Copy link
Member Author

This ones weird: https://travis-ci.org/ipfs/go-ipfs/jobs/61101632

Also, I cannot reproduce this failure locally... before this fix, i could, but not now... maybe i vendored the wrong thing?

@jbenet
Copy link
Member

jbenet commented May 4, 2015

@whyrusleeping LGTM. squash + merge?

@whyrusleeping
update iptb dependency and use different ports for each iptb cluster
9cf8c5c 
update iptb dependency again, and pick different ports for each iptb cluster

try and fix godeps crap
jbenet added a commit that referenced this pull request May 5, 2015
@jbenet
Merge pull request #1194 from ipfs/fix/iptb-fails
9a5bb52 
increase iptb test stability
@jbenet jbenet merged commit 9a5bb52 into master May 5, 2015
@jbenet jbenet deleted the fix/iptb-fails branch May 5, 2015 02:55
@jbenet jbenet removed the status/in-progress In progress label May 5, 2015
@jbenet jbenet mentioned this pull request May 9, 2015
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) kind/test Testing work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@whyrusleeping @jbenet