Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cdk/cdk
base: fafd8b328128
Choose a base ref
...
head repository: cdk/cdk
compare: a0c9dc764373
Choose a head ref
  • 7 commits
  • 5 files changed
  • 1 contributor

Commits on May 4, 2015

  1. Minor tidy up/variable renaming.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    b0c9468 View commit details
    Browse the repository at this point in the history
  2. Use newer SMARTS/Substructure API calls.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    1d76286 View commit details
    Browse the repository at this point in the history
  3. contains does an identity check and is therefore redunant - unless so…

    …me extra logic was intended here?
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    cb28cde View commit details
    Browse the repository at this point in the history
  4. Extract new pcore atom creation to method.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    b1c2c43 View commit details
    Browse the repository at this point in the history
  5. There appears to be some equality logic in the PCoreAtom so the conta…

    …ins check on IAtomContainer might be needed. However it was still doing reference equality, behaviour is now working as expected.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    58cccb6 View commit details
    Browse the repository at this point in the history
  6. Slightly faster tests using silent and avoiding redundant setup.

    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    bf8dbbd View commit details
    Browse the repository at this point in the history
  7. Use new Mappings API - the current pcore API doesn't really fit well …

    …since the mappings is lazy and it is redone multiple times. However the new calls are now decoupled and only required calling of matches() instead of other methods in order. Dirrect return of Mappings instance (ala. Pattern.matchAll) would perhaps be better - also interfaces (List<Map> instead List<HashMap>) would be an improvement but would break existing usages.
    
    Signed-off-by: Egon Willighagen <egonw@users.sourceforge.net>
    johnmay authored and egonw committed May 4, 2015
    Copy the full SHA
    a0c9dc7 View commit details
    Browse the repository at this point in the history