core/corenet: Remove this unused package #1184
Conversation
It was renamed from core/net.go in d8d933c (move core/net.go to 'corenet' and change interface a tad, 2015-02-14), but no consumer imports were updated in that commit. I've searched the Git history looking for the previous consumers, but [.]Dial[(] and [.]Listen[(] match a lot of stuff ;). GoDoc doesn't list any consumers (either inside or outside this repository [1]. [1]: https://godoc.org/github.com/ipfs/go-ipfs/core/corenet
|
nope. this one is not unused. I have a bunch of different programs that import ipfs as a library and use this. |
|
including this: #1089 |
|
On Sat, May 02, 2015 at 12:03:39PM -0700, Jeromy Johnson wrote:
Good to know. You should probably search for those projects on GoDoc, |
GoDoc only lists a minority of dependencies. Many packages will never be released in the open and thus will never show up as dependencies. we cannot make assumptions like "nobody is importing this because godos/sourcegraph/etc don't show anything". |
|
On Sat, May 02, 2015 at 01:18:03PM -0700, Juan Batiz-Benet wrote:
#1089 landing will restore local consumers (still missing docs and |
It was renamed from core/net.go in d8d933c (move core/net.go to
'corenet' and change interface a tad, 2015-02-14), but no consumer
imports were updated in that commit. I've searched the Git history
looking for the previous consumers, but [.]Dial[(] and [.]Listen[(]
match a lot of stuff ;). GoDoc doesn't list any consumers (either
inside or outside this repository 1.