Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: foswiki/distro
base: 96d6e20600d7
Choose a base ref
...
head repository: foswiki/distro
compare: df238af1ca96
Choose a head ref
  • 5 commits
  • 6 files changed
  • 1 contributor

Commits on May 5, 2015

  1. Item13391: Minor update to SendTestEmail wizard 

    When run under the cli tools/configure, the Engine is not defined, and
the wizard crashes.
    @gac410
    gac410 committed May 5, 2015
    Copy the full SHA
    f332b51 View commit details
    Browse the repository at this point in the history

  2. Item13391: Unable to save config after removing an extension 

    The plugin module is not undefok,  but that prevents it from being
deleted from the configuration during save.

SMELL:  Not sure that this is the right fix. Any extension related
setting needs to allow undefined, if the extension has been uninstalled.
    @gac410
    gac410 committed May 5, 2015
    Copy the full SHA
    81090cd View commit details
    Browse the repository at this point in the history

  3. Item13391: Extend the extensions installer wizard 

    It needs to not treat installer related options as extension names or
repositories.  Build a common list of Package.pm options for exclusion.

Add a new "manifest" method.  It currently will only be used from the
shell installer.
    @gac410
    gac410 committed May 5, 2015
    Copy the full SHA
    78df763 View commit details
    Browse the repository at this point in the history

  4. Item13391: Minor issues with Package.pm 

     - The options need better documentation

 - The reports needed some blank lines for readability

 - For some reason, it was not always detecting changes in the modified
   configuration settings.  Since the Save wizard correctly detects when
   changes are required, just make the changes, rather than testing the
   $Foswiki::cfg hash to see if they are needed.

 - Also add an ENABLE option to allow control over whether or not the
   extension should be enabled.  Default from web installer will be to
   enable all plugins, because the user has the final decision on
   whether or not to save, and what to save.   The control is more
   needed when using tools/configure, as the save is all or nothing.
   It's important to always save the merged Config.spec,  but the
   enable/disable decision should be separate.
    @gac410
    gac410 committed May 5, 2015
    Copy the full SHA
    19193eb View commit details
    Browse the repository at this point in the history

  5. Item13391: Major refactor of extender.pl and tools/configure 

    tools/configure has some very big advantages when used to install
extensions.
   - It merges in the config.spec
   - It allows the extension to be enabled
   - It saves the configuration

The old extender.pl can't do any of that.

This commit changes extender.pl to merely reconfigure the commandline
arguments and "do" tools/configure to install the extensions.  This
greatly simplifies the code, and centralizes all installation work into
the Wizard and Package.pm.

In order to make tools/configure more "friendly" to the cli user, this
changes the $reporter to use print STDERR statements instead of doing a
"Data::Dumper" of the reporter messages hash.
    @gac410
    gac410 committed May 5, 2015
    Copy the full SHA
    df238af View commit details
    Browse the repository at this point in the history