Don't call looping Module#constants from loop in Type.include_modules…

…_from. This looping over the same series of direct_superclasses is exponentially redundant and wasteful (not to mention the extra overhead in Module#constants).
rubinius · May 3, 2015 · bd8361b · bd8361b
1 parent 8c898e7
commit bd8361b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/kernel/common/type.rb b/kernel/common/type.rb
@@ -322,7 +322,7 @@ def self.include_modules_from(included_module, klass)
             changed = true
           end
 
-          constants_changed ||= mod.constants.any?
+          constants_changed ||= mod.constant_table.size > 0
         end
 
         mod = mod.direct_superclass