Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require 'ripper' yields const already init warnings #2904

Closed
cpuguy83 opened this issue May 1, 2015 · 2 comments
Closed

require 'ripper' yields const already init warnings #2904

cpuguy83 opened this issue May 1, 2015 · 2 comments
Milestone
JRuby 9.0.0.0.rc1

Comments

@cpuguy83
Copy link

cpuguy83 commented May 1, 2015

When trying to require ripper on jruby 9k-pre2 we get these warnings:

/opt/jruby/lib/ruby/stdlib/ripper/core.rb:13: warning: already initialized constant SCANNER_EVENT_TABLE
/opt/jruby/lib/ruby/stdlib/ripper/core.rb:13: warning: already initialized constant PARSER_EVENT_TABLE
/opt/jruby/lib/ruby/stdlib/ripper/core.rb:13: warning: already initialized constant Version
/opt/jruby/lib/ruby/stdlib/ripper/core.rb:13: warning: already initialized constant SCRIPT_LINES__

Looking at the referenced core.rb, the only thing I can see is that before doing anything it's requiring ripper.jar... so I'm assuming that these constants are being defined in there.
@cpuguy83 cpuguy83 mentioned this issue May 1, 2015
Merged
@enebo enebo closed this as completed in d58fd29 May 1, 2015
@enebo enebo modified the milestones: JRuby 9.0.0.0, JRuby 9.0.0.0.rc1 May 1, 2015
@enebo
Copy link
Member

enebo commented May 1, 2015

Hmmm, apparently I added the right mojo in the ripper.jar for it to load itself. @headius can you commit this ripper.rb change to MRI upstream?

headius added a commit to jruby/ruby that referenced this issue May 1, 2015
@headius
ripper.jar has the magic to boot itself now. Fixes jruby/jruby#2904
a0951c6
@headius
Copy link
Member

headius commented May 5, 2015

Updated our stdlib in jruby/ruby@a0951c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.0.0.0.rc1
Development

No branches or pull requests
3 participants
@headius @enebo @cpuguy83