opal · May 2, 2015 · May 2, 2015 · May 2, 2015 · May 2, 2015 · May 2, 2015
Showing with 5 additions and 20 deletions.

+1 −1 opal/corelib/string.rb

+1 −1 spec/corelib

+2 −18 spec/filters/bugs/string.rb

+1 −0 spec/rubyspecs
diff --git a/opal/corelib/string.rb b/opal/corelib/string.rb
@@ -386,7 +386,7 @@ def each_line(separator = $/)
         return self;
       }
 
-      var chomped  = #{chomp},
+      var chomped  = #{chomp(separator)},
           trailing = self.length != chomped.length,
           splitted = chomped.split(separator);
 

diff --git a/spec/corelib b/spec/corelib
diff --git a/spec/filters/bugs/string.rb b/spec/filters/bugs/string.rb
@@ -1,28 +1,19 @@
 opal_filter "String" do
+  #The following two failures are waiting for https://github.com/opal/opal/issues/710 to be fixed
   fails "String#[] with Range calls to_int on range arguments"
+  fails "String#slice with Range calls to_int on range arguments"
 
   fails "String#clone copies singleton methods"
   fails "String#clone copies modules included in the singleton class"
   fails "String#clone does not modify the original string when changing cloned string"
 
   fails "String#dup does not copy constants defined in the singleton class"
 
-  fails "String#each_line uses $/ as the separator when none is given"
   fails "String#each_line yields subclass instances for subclasses"
 
-  fails "String#lines uses $/ as the separator when none is given"
   fails "String#lines yields subclass instances for subclasses"
 
-  #The following failure is a side-effect of a symbol being used in one of the assertions:
-  fails "String#scan raises a TypeError if pattern isn't a Regexp and can't be converted to a String"
-
-  #The following failure is a side-effect of the currently broken MatchData#offset implementation:
-  fails "String#scan with pattern and block sets $~ for access from the block"
-
-  fails "String#slice with Range calls to_int on range arguments"
-
   fails "String#split with String returns subclass instances based on self"
-  fails "String#split with Regexp respects $KCODE when splitting between characters"
   fails "String#split with Regexp includes all captures in the result array"
   fails "String#split with Regexp does not include non-matching captures in the result array"
   fails "String#split with Regexp returns subclass instances based on self"
@@ -119,13 +110,6 @@
   fails "String#to_r understands a forward slash as separating the numerator from the denominator"
   fails "String#to_r returns (0/1) for Strings it can't parse"
 
-  fails "String#crypt returns a cryptographic hash of self by applying the UNIX crypt algorithm with the specified salt"
-  fails "String#crypt raises an ArgumentError when the salt is shorter than two characters"
-  fails "String#crypt calls #to_str to converts the salt arg to a String"
-  fails "String#crypt raises a type error when the salt arg can't be converted to a string"
-  fails "String#crypt taints the result if either salt or self is tainted"
-  fails "String#crypt doesn't return subclass instances"
-
   fails "String#dump taints the result if self is tainted"
   fails "String#dump untrusts the result if self is untrusted"
   fails "String#dump returns a subclass instance"

diff --git a/spec/rubyspecs b/spec/rubyspecs
@@ -80,6 +80,7 @@ corelib/core/range/new_spec
 corelib/core/range/size_spec
 
 corelib/core/string
+!corelib/core/string/crypt_spec
 !corelib/core/string/scrub_spec
 
 corelib/core/symbol/to_proc_spec