Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash#take_while wrong behavior in 1.7.19 #2907

Closed
dzjuck opened this issue May 5, 2015 · 4 comments
Closed

Hash#take_while wrong behavior in 1.7.19 #2907

dzjuck opened this issue May 5, 2015 · 4 comments
Assignees
@kares
Labels
core JRuby 1.7.x
Milestone
JRuby 1.7.21

Comments

@dzjuck
Copy link

dzjuck commented May 5, 2015 

passed = []
hash = {a: 1}
hash.take_while { |pair| passed << pair; true }
passed
# [:a] # jruby-1.7.19
# [[:a, 1]] # jruby-head
# [[:a, 1]] # mri-1.9.3
# [[:a, 1]] # mri-2.2.1

Thank you.
@nirvdrum
Copy link
Contributor

nirvdrum commented May 5, 2015

This appears to be problematic in 1.7.19 as well.

@dzjuck
Copy link
Author

dzjuck commented May 5, 2015

@nirvdrum Thank you, it's typo, i meant 1.7.19

@dzjuck dzjuck changed the title Hash#take_while wrong behavior in 1.7.9 Hash#take_while wrong behavior in 1.7.19 May 5, 2015
@nirvdrum
Copy link
Contributor

nirvdrum commented May 5, 2015

No worries. We often get bug reports against older versions of JRuby. So I like to verify that the problem is still present in the most recently released version.

@kares kares added this to the JRuby 1.7.21 milestone May 5, 2015
@dzjuck dzjuck mentioned this issue May 13, 2015
Merged
@kares kares self-assigned this May 26, 2015
kares added a commit to kares/jruby that referenced this issue May 26, 2015
@kares
fix Hash#take_while wrong behavior + inline-paste block local arg pac…
0d9ed02 
…king (jruby#2907)
kares added a commit to kares/jruby that referenced this issue May 26, 2015
@kares
fix Hash#take_while wrong behavior + inline-paste block local arg pac…
57e38d1 
…king (jruby#2907)
kares added a commit to kares/jruby that referenced this issue May 27, 2015
@kares
fix Hash#take_while wrong behavior + inline-paste block local arg pac…
45a6459 
…king (jruby#2907)
kares added a commit to kares/jruby that referenced this issue May 28, 2015
@kares
fix Hash#take_while wrong behavior + inline-paste block local arg pac…
2415179 
…king (jruby#2907)
kares added a commit to kares/jruby that referenced this issue May 29, 2015
@kares
fix Hash#take_while wrong behavior + inline-paste block local arg pac…
d8aa8af 
…king (jruby#2907)
@kares
Copy link
Member

kares commented May 29, 2015

closing on jruby-1_7 with d8aa8af

@kares kares closed this as completed May 29, 2015
@kares kares mentioned this issue Jul 15, 2015
Closed
@donv donv mentioned this issue Jul 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kares kares

Labels
core JRuby 1.7.x
Projects
None yet
Milestone
JRuby 1.7.21
Development

No branches or pull requests
3 participants
@nirvdrum @kares @dzjuck