Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cleanup pt deux #103

Merged
merged 2 commits into from May 2, 2015
Merged

Test cleanup pt deux #103

merged 2 commits into from May 2, 2015

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented May 2, 2015

No description provided.

@zmughal @mohawk2
Test code should not be duplicated between TODO and non-TODO branches
156a8f0 
We can use the same code and mark it conditionally as TODO by doing:

    TODO: {
    	local $TODO = 'why' if $condition;

    	... # tests
    }
@zmughal @mohawk2
spelling: s|exspecting|expecting|
973baea
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 973baea on test-cleanup-pt-deux into * on master*.

@mohawk2 mohawk2 merged commit 973baea into master May 2, 2015
@mohawk2 mohawk2 deleted the test-cleanup-pt-deux branch May 2, 2015 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mohawk2 @coveralls @zmughal