Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Stat::stat_birthtime. #3439

Merged
merged 1 commit into from Jun 13, 2015
Merged

Fix Stat::stat_birthtime. #3439

merged 1 commit into from Jun 13, 2015

Conversation

ruipserra
Copy link
Contributor

This commit fixes a build error due to a signature mismatch of the Time::at
method and the way it was being used in Stat::stat_birthtime.

The build error was:

vm/builtin/stat.cpp:82:30: error: no viable conversion from 'struct timespec' to 'time64_t' (aka 'long long')
      return Time::at(state, st_.st_birthtimespec);
                             ^~~~~~~~~~~~~~~~~~~~
/Users/ruiserra/code/ruby/ruipserra/rubinius/vm/builtin/time.hpp:40:37: note: passing argument to parameter 'seconds' here
    static Time* at(STATE, time64_t seconds, long nanoseconds = 0);
                                    ^

@ruipserra
Fix Stat::stat_birthtime.
12b906b 
This commit fixes a build error due to a signature mismatch of the Time::at
method and the way it was being used in Stat::stat_birthtime.
@jemc
Copy link
Member

jemc commented Jun 13, 2015

Hm, I wonder why Travis isn't running this to confirm the build.

@ruipserra
Copy link
Contributor Author

Even though 2.2 was added to .travis.yml (#3413), I don't see it in the branches list in the UI. And in https://travis-ci.org/rubinius/rubinius/requests it lists this PR as "branch not included or excluded".

@jemc
Copy link
Member

jemc commented Jun 13, 2015

This looks good to me, although its irksome that Travis won't run it for us.

jemc added a commit that referenced this pull request Jun 13, 2015
@jemc
Merge pull request #3439 from ruipserra/fix_stat_birthtime
b2a8222 
Fix Stat::stat_birthtime.
@jemc jemc merged commit b2a8222 into rubinius:2.2 Jun 13, 2015
@ruipserra
Copy link
Contributor Author

Thanks!

@brixen
Copy link
Member

brixen commented Jun 13, 2015

I've pinged Travis about this (no response), run lint on our .travis.yml, re-read the docs. I have no idea why it's not working. Annoying for sure.

@tak1n
Copy link
Member

tak1n commented Jun 15, 2015

@ruipserra Thanks for fixing this, not sure why I was able to build it with this mismatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ruipserra @jemc @brixen @tak1n