Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
base: 85d670e5a2ce
Choose a base ref
...
head repository: nodejs/node-v0.x-archive
compare: 10349829f2f4
Choose a head ref
  • 7 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 4, 2015

  1. test: running tls-server-verify clients in parallel 

    OpenSSL s_client introduces some delay on Windows. With all clients
running sequentially, this delay is big enough to break CI. This fix runs
the clients in parallel (unless the test includes renegotiation),
reducing the total run time.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    1191e65 View commit details
    Browse the repository at this point in the history

  2. test: run tls-server-verify servers in parallel 

    Different servers must use different ports. Since we can count only on
common.PORT and common.PORT+1, run only 2 servers in parallel.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    6d34505 View commit details
    Browse the repository at this point in the history

  3. test: improve console output of tls-server-verify 

    When running in parallel, it is not easy to identify what server and
client failed when the test fails. This adds identifiers to all lines
of console output.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @joaocgreis @orangemocha
    joaocgreis authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    29bbb32 View commit details
    Browse the repository at this point in the history

  4. test,win: re-enable tls-server-verify in CI 

    Now that the test is fixed, node-accept-pull-request should
fail when the test fails.

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @orangemocha
    orangemocha committed Jun 4, 2015
    Copy the full SHA
    83b7c07 View commit details
    Browse the repository at this point in the history

  5. test: kill child in tls-server-verify for speed up 

    For better performance of the test, the parent kills child processes
so as not to wait them to be ended.

(cherry picked from commit 833b236)

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    cb63d93 View commit details
    Browse the repository at this point in the history

  6. deps: add -no_rand_screen to openssl s_client 

    In openssl s_client on Windows, RAND_screen() is invoked to initialize
random state but it takes several seconds in each connection.
This added -no_rand_screen to openssl s_client on Windows to skip
RAND_screen() and gets a better performance in the unit test of
test-tls-server-verify.
Do not enable this except to use in the unit test.

(cherry picked from commit 9f0f7c3)

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    fa4aa34 View commit details
    Browse the repository at this point in the history

  7. test: add -no_rand_screen for tls-server-verify 

    This improves the performance of openssl s_client on Windows and
gains several seconds to finish test-tls-server-verify.

(cherry picked from commit 2ff517e)

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25368
    @orangemocha
    Shigeki Ohtsu authored and orangemocha committed Jun 4, 2015
    Copy the full SHA
    1034982 View commit details
    Browse the repository at this point in the history