Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby 1.7.20 error when requiring krypt/ossl #3024

Closed
tbeauvais opened this issue Jun 6, 2015 · 4 comments
Closed

JRuby 1.7.20 error when requiring krypt/ossl #3024

tbeauvais opened this issue Jun 6, 2015 · 4 comments

Comments

@tbeauvais
Copy link

After switching to JRuby 1.7.20 one of our internal gems is failing because it does a require 'krypt/ossl'. I'm assuming it's not needed anymore since JRuby 1.7.20 bundles jruby-openssl 0.9.6, but it is a breaking change since this gem supports older version of JRuby.

@mkristian
Copy link
Member

mkristian commented Jun 7, 2015 via email

@tbeauvais
Copy link
Author

I think it may have added the "require" because of this issue: #719

@mkristian
Copy link
Member

mkristian commented Jun 8, 2015 via email

@kares
Copy link
Member

kares commented Jun 14, 2015

as @mkristian already suggested, krypt was really an "internal" gem to get PKCS5 support in OpenSSL

... thus we ended up having a lot of krypt code just to "emulate" 2 methods - we can not avoid users requiring files from default gems but best practice is to never assume any require outside the stdlib to work and have a gem dependency instead (what if a newer bundled krypt did not work with your internal gems - you would need to adjust the gem anyway for newer JRuby 1.7.x).

@kares kares closed this as completed Jun 14, 2015
@kares kares added this to the Invalid or Duplicate milestone Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants