Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some CAPI fixes #3432

Merged
merged 2 commits into from Jun 10, 2015
Merged

Some CAPI fixes #3432

merged 2 commits into from Jun 10, 2015

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jun 10, 2015

No description provided.

@jemc
Copy link
Member

jemc commented Jun 10, 2015

I would probably merge this for you now if it weren't for the changes to configure - I don't know much about OSX or brew so I can't confirm those changes.

@tamird
Copy link
Contributor Author

tamird commented Jun 10, 2015

I promise that configure didn't work before the change, and does after the change :)

@tamird
Copy link
Contributor Author

tamird commented Jun 10, 2015

I've updated this to run CI on OSX

yorickpeterse
yorickpeterse reviewed Jun 10, 2015
View reviewed changes
.travis.yml
- if [ $TRAVIS_OS_NAME == linux ]; then sudo apt-get update && sudo apt-get install -y llvm-3.4 llvm-3.4-dev; fi
- if [ $TRAVIS_OS_NAME == osx ]; then brew update && brew install llvm && brew link --force llvm; fi
- if [ $TRAVIS_OS_NAME == linux ]; then sudo apt-get update && sudo apt-get install -y llvm-3.5 llvm-3.5-dev; fi
- if [ $TRAVIS_OS_NAME == osx ]; then brew update && brew install llvm35 && brew link --force llvm35; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehm, this won't work once llvm35 is no longer available or when we need LLVM 3.6. I'm pretty sure the "llvm" homebrew package is supposed to be a link to the latest version. These Travis changes need to be at least in a separate PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llvm35 will be available for ever, it's from homebrew/versions

@yorickpeterse yorickpeterse added the C-API Compatibility Function and feature compatibility with the MRI C-API label Jun 10, 2015
@tamird
Copy link
Contributor Author

tamird commented Jun 10, 2015

Removed travis/configure changes, will open a new PR for those. PTAL.

@tamird
Copy link
Contributor Author

tamird commented Jun 10, 2015

Added tests!

@tamird
Copy link
Contributor Author

tamird commented Jun 10, 2015

Green, PTAL.

jemc added a commit that referenced this pull request Jun 10, 2015
@jemc
Merge pull request #3432 from tamird/fix-problems
315e3bf 
Some CAPI fixes
@jemc jemc merged commit 315e3bf into rubinius:master Jun 10, 2015
@jemc
Copy link
Member

jemc commented Jun 10, 2015

Thanks!

@tamird tamird deleted the fix-problems branch June 10, 2015 18:27
@yorickpeterse
Copy link
Contributor

Sweet, thanks!

@tamird tamird mentioned this pull request Sep 6, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-API Compatibility Function and feature compatibility with the MRI C-API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tamird @jemc @yorickpeterse