-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some CAPI fixes #3432
Some CAPI fixes #3432
Conversation
I would probably merge this for you now if it weren't for the changes to |
I promise that |
I've updated this to run CI on OSX |
- if [ $TRAVIS_OS_NAME == linux ]; then sudo apt-get update && sudo apt-get install -y llvm-3.4 llvm-3.4-dev; fi | ||
- if [ $TRAVIS_OS_NAME == osx ]; then brew update && brew install llvm && brew link --force llvm; fi | ||
- if [ $TRAVIS_OS_NAME == linux ]; then sudo apt-get update && sudo apt-get install -y llvm-3.5 llvm-3.5-dev; fi | ||
- if [ $TRAVIS_OS_NAME == osx ]; then brew update && brew install llvm35 && brew link --force llvm35; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehm, this won't work once llvm35 is no longer available or when we need LLVM 3.6. I'm pretty sure the "llvm" homebrew package is supposed to be a link to the latest version. These Travis changes need to be at least in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
llvm35 will be available for ever, it's from homebrew/versions
Removed travis/configure changes, will open a new PR for those. PTAL. |
Added tests! |
Green, PTAL. |
Thanks! |
Sweet, thanks! |
No description provided.