Adopting to Redesigned Truffle Inter-operability API #3017
Conversation
|
|
||
| public WritePropertyNode(RubyContext context, SourceSection sourceSection) { | ||
| super(context, sourceSection); | ||
| this.node = ForeignObjectAccessNode.getAccess(Write.create(Receiver.create(), Argument.create(), Argument.create())); | ||
| this.node = ForeignAccess.node(ForeignAccess.msgWrite()); |
There was a problem hiding this comment.
Are these node methods factories or something? The name is strange - being a noun rather than a verb.
There was a problem hiding this comment.
Yeah, Christian Humer had similar comment. He wanted to rename node to createNode and msgXYZ to something else as well. The msgXYZ methods are however more like singleton accessors than factories.
There was a problem hiding this comment.
I think as well createNode would be clearer if it is a factory method, .node could be like a getter, or possibly implies some caching (does it?).
Would an enum or constants make sense for the msgXYZ if they are singleton instances?
|
This all looks fine. Do you want this merged now, or later? |
|
My plan is to integrate the API changes on Monday. Then you'll need this PR. |
I am in process of redesigning com.oracle.truffle.api.interop API. Once that gets into development version of Truffle, JRuby+Truffle will need to be adopted. This pull request shows what changes I had to do make things running.