Don't warn on private attribute accessors to match CRuby

I'm sorry for the back and forth on this one. I introduced it back in #2637, but CRuby have recently removed the warning in https://bugs.ruby-lang.org/issues/10967.
jruby · Jun 4, 2015 · c30264c · c30264c
1 parent c406290
commit c30264c
Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/core/src/main/java/org/jruby/RubyModule.java b/core/src/main/java/org/jruby/RubyModule.java
@@ -1597,9 +1597,7 @@ private void addAccessor(ThreadContext context, String internedName, Visibility
 
         final Ruby runtime = context.runtime;
 
-        if (visibility == PRIVATE) {
-            runtime.getWarnings().warn(ID.PRIVATE_ACCESSOR, "private attribute?");
-        } else if (visibility == MODULE_FUNCTION) {
+        if (visibility == MODULE_FUNCTION) {
             runtime.getWarnings().warn(ID.ACCESSOR_MODULE_FUNCTION, "attribute accessor as module_function");
             visibility = PRIVATE;
         }

diff --git a/core/src/main/java/org/jruby/common/IRubyWarnings.java b/core/src/main/java/org/jruby/common/IRubyWarnings.java
@@ -73,7 +73,6 @@ public enum ID {
         NOT_IMPLEMENTED,
         OBSOLETE_ARGUMENT,
         PARENTHISE_ARGUMENTS,
-        PRIVATE_ACCESSOR,
         PROXY_EXTENDED_LATE,
         STATEMENT_NOT_REACHED, 
         LITERAL_IN_CONDITIONAL_RANGE,

diff --git a/test/mri/ruby/test_module.rb b/test/mri/ruby/test_module.rb
@@ -833,15 +833,14 @@ def test_export_method
   end
 
   def test_attr
-    assert_in_out_err([], <<-INPUT, %w(:ok nil), /warning: private attribute\?$/)
+    assert_in_out_err([], <<-INPUT, %w(nil))
       $VERBOSE = true
       c = Class.new
       c.instance_eval do
         private
         attr_reader :foo
       end
       o = c.new
-      o.foo rescue p(:ok)
       p(o.instance_eval { foo })
     INPUT