Skip to content

Commit

Permalink
Showing 3 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions core/src/main/java/org/jruby/RubyModule.java
Original file line number Diff line number Diff line change
@@ -1597,9 +1597,7 @@ private void addAccessor(ThreadContext context, String internedName, Visibility

final Ruby runtime = context.runtime;

if (visibility == PRIVATE) {
runtime.getWarnings().warn(ID.PRIVATE_ACCESSOR, "private attribute?");
} else if (visibility == MODULE_FUNCTION) {
if (visibility == MODULE_FUNCTION) {
runtime.getWarnings().warn(ID.ACCESSOR_MODULE_FUNCTION, "attribute accessor as module_function");
visibility = PRIVATE;
}
1 change: 0 additions & 1 deletion core/src/main/java/org/jruby/common/IRubyWarnings.java
Original file line number Diff line number Diff line change
@@ -73,7 +73,6 @@ public enum ID {
NOT_IMPLEMENTED,
OBSOLETE_ARGUMENT,
PARENTHISE_ARGUMENTS,
PRIVATE_ACCESSOR,
PROXY_EXTENDED_LATE,
STATEMENT_NOT_REACHED,
LITERAL_IN_CONDITIONAL_RANGE,
3 changes: 1 addition & 2 deletions test/mri/ruby/test_module.rb
Original file line number Diff line number Diff line change
@@ -833,15 +833,14 @@ def test_export_method
end

def test_attr
assert_in_out_err([], <<-INPUT, %w(:ok nil), /warning: private attribute\?$/)
assert_in_out_err([], <<-INPUT, %w(nil))
$VERBOSE = true
c = Class.new
c.instance_eval do
private
attr_reader :foo
end
o = c.new
o.foo rescue p(:ok)
p(o.instance_eval { foo })
INPUT

0 comments on commit c30264c

Please sign in to comment.