Fix #1810 -- use watchdog in auto #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You mean rebuilds were not working? |
|
yeah, I broke them in f1e95ef and nobody really noticed… |
|
let's merge this then :) |
|
So is pyyaml no longer a huge problem? |
|
Well, at least cherrypick the fix? We can merge this later, then. |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
done |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
@Kwpolska let's merge this, dependencies be damned. |
Kwpolska
added a commit
that referenced
this pull request
Jun 15, 2015
Fix #1810 -- use watchdog in auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #1810.
Fixes (some of which would be useful even without
watchdog):make rebuilds actually workcherry-picked onto masterAlso, we have to watch the directory with
conf.pyand filter out events because you must watch entire directories withwatchdog.cc @ralsina