-
-
Notifications
You must be signed in to change notification settings - Fork 925
Comparing changes
Open a pull request
base repository: jruby/jruby
base: 3528613cc58c
head repository: jruby/jruby
compare: 294bf2765262
- 18 commits
- 23 files changed
- 5 contributors
Commits on Jun 5, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 410cdee - Browse repository at this point
Copy the full SHA 410cdeeView commit details -
Don't call modify() on RubyStrings so eagerly when freezing them
This fixes #3019, where in certain cases it's possible to end up with RubyString instances backed by very large unique ByteLists where only a tiny portion of the bytes in the ByteList are actually needed. What was happening is `modify` was being called on RubyString instances too eagerly, resulting in unnecessary duplication of their underlying ByteList instances instead of sharing when possible. The two changes here are in `RubyString#newFrozen` and `RubyString#resize` and I believe are more correct based on the C implementation of these methods. For `RubyString#newFrozen`, which roughly corresponds to `rb_str_new_frozen` in C (https://github.com/ruby/ruby/blob/v2_2_2/string.c#L932), the logic looks to me to return the shared string and I don't see it calling `str_make_independent`, which is roughly the same thing as `RubyString#modify`. So, I just removed the call to `modify`. For `RubyString#resize`, which roughly corresponds to to `rb_str_resize` in C, shared strings are only made independent if their length differ (https://github.com/ruby/ruby/blob/v2_2_2/string.c#L2155). Thus, instead of unconditionally calling `modify` here, I moved it into the conditions that are true when the length differs.
Configuration menu - View commit details
-
Copy full SHA for 4fb81b7 - Browse repository at this point
Copy the full SHA 4fb81b7View commit details -
Merge pull request #3022 from bbrowning/string-cow-oom
Don't call modify() on RubyStrings so eagerly when freezing them
Configuration menu - View commit details
-
Copy full SHA for f4ede91 - Browse repository at this point
Copy the full SHA f4ede91View commit details -
1
Configuration menu - View commit details
-
Copy full SHA for 8f4ec6b - Browse repository at this point
Copy the full SHA 8f4ec6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f4a988b - Browse repository at this point
Copy the full SHA f4a988bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c4249fa - Browse repository at this point
Copy the full SHA c4249faView commit details -
Fix the slow test indexes so test:slow_suites runs tests again
This has been broken since July 2014 when some tests were moved from test/ to test/jruby/. Thus, once reenabled some of these tests have failures.
Configuration menu - View commit details
-
Copy full SHA for 3f59de2 - Browse repository at this point
Copy the full SHA 3f59de2View commit details -
Revert "[Truffle] Remove use of Java 8 method."
This reverts commit c4249fa.
Configuration menu - View commit details
-
Copy full SHA for cb97f5a - Browse repository at this point
Copy the full SHA cb97f5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbdd0ab - Browse repository at this point
Copy the full SHA bbdd0abView commit details -
Merge pull request #3023 from bbrowning/slow_suites
Fix the slow test indexes so test:slow_suites runs tests again
Configuration menu - View commit details
-
Copy full SHA for 828fad3 - Browse repository at this point
Copy the full SHA 828fad3View commit details
Commits on Jun 8, 2015
-
Update ripper parser to line up with mainline parser. Fix lineno to p…
…ass all but 8 specs on Yard.
Configuration menu - View commit details
-
Copy full SHA for 86dfb5d - Browse repository at this point
Copy the full SHA 86dfb5dView commit details -
Ripper on_params handling of kw were using hash and not array and cra…
…shing for reqd kwargs
Configuration menu - View commit details
-
Copy full SHA for 1d1e883 - Browse repository at this point
Copy the full SHA 1d1e883View commit details
Commits on Jun 9, 2015
-
Configuration menu - View commit details
-
Copy full SHA for b81d378 - Browse repository at this point
Copy the full SHA b81d378View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1baad69 - Browse repository at this point
Copy the full SHA 1baad69View commit details -
Configuration menu - View commit details
-
Copy full SHA for b96813f - Browse repository at this point
Copy the full SHA b96813fView commit details -
Fix new id values for true,false,nil. Workaround #3028 so we can test…
… the behavior of finalization in ObjectSpace
Configuration menu - View commit details
-
Copy full SHA for 9f76735 - Browse repository at this point
Copy the full SHA 9f76735View commit details -
Revert "Revert "Merge branch 'truffle-symbol-refactor'""
This reverts commit bbdd0ab.
Configuration menu - View commit details
-
Copy full SHA for eb4f675 - Browse repository at this point
Copy the full SHA eb4f675View commit details -
Configuration menu - View commit details
-
Copy full SHA for 294bf27 - Browse repository at this point
Copy the full SHA 294bf27View commit details
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.