Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zlib::GzipReader.readbyte not implemented #3041

Closed
BiraLookout opened this issue Jun 12, 2015 · 3 comments
Closed

Zlib::GzipReader.readbyte not implemented #3041

BiraLookout opened this issue Jun 12, 2015 · 3 comments
Labels
stdlib
Milestone
JRuby 1.7.21

Comments

@BiraLookout
Copy link

GzipReader doesn't seem to implement readbyte, throwing NoMethodError when called.
@headius
Copy link
Member

headius commented Jun 15, 2015

Looks like it's a trivial wrapper around getbyte.

@headius
Copy link
Member

headius commented Jun 15, 2015

Looks like it was added in 1.9, so we should do this for JRuby 1.7.21 too.

@headius headius added this to the JRuby 1.7.21 milestone Jun 15, 2015
@headius headius added the stdlib label Jun 15, 2015
headius added a commit that referenced this issue Jun 15, 2015
@headius
Add GzipReader#readbyte. Fixes #3041
0745433
@headius
Copy link
Member

headius commented Jun 15, 2015

I noticed there's no tests for either getbyte or readbyte. Perhaps you'd help us out and add something to https://github.com/ruby/rubyspec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib
Projects
None yet
Milestone
JRuby 1.7.21
Development

No branches or pull requests
2 participants
@headius @BiraLookout