Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline never works with Inline:MakeMaker for Pdlpp and others #55

Open
leonid-butenko opened this issue Jun 10, 2015 · 3 comments
Open

Comments

@leonid-butenko
Copy link

Hi there,

I think I have discovered a bug in Inline perl module. In Inline.pm's install routine (version 0.55), there is a check for language name which is apparently wrong for most of the languages:

http://cpansearch.perl.org/src/SISYPHUS/Inline-0.55/Inline.pm (also here on github version 0.80)

croak M64_install_not_c($o->{API}{language_id})
    unless uc($o->{API}{language_id}) =~ /^(C|CPP|Java|Python|Ruby|Lisp|Pdlpp)$/ ;

Upper case will never match Python, Pdlpp etc. Pls advise..

regards,
Leo

@mohawk2
Copy link
Collaborator

mohawk2 commented Jun 10, 2015

You are correct. The "install" functionality of Inline has never worked brilliantly. Check out Inline::Module instead.

@leonid-butenko
Copy link
Author

Hey, thanks for the advice ... I tried to use Inline::Module instead but it doesn't look one to one replacement. Can you suggest about the following problem?

If i generate a tarball from my package using make dist the inline stub generated is getting substituted with the DynaLoader version. Although if I'm running make install - it keeps using the standard one like this:

use strict; use warnings;
package pdlinc::Inline;
use Inline::Module stub => 'v2';

To my understanding this should work same as make dist, shouldn't it ?

@mohawk2
Copy link
Collaborator

mohawk2 commented Jun 14, 2015

The above, if I understand you right, is all build-time stuff. The purpose of I::M is that after it is installed, only the DynaLoader will be in the installed version, and it will all "just work". Have you tried that? You'd probably be best off using a "perlbrew"-ed perl to try it, rather than your system perl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants