Update ModeShape -> 4.4.0, and ISPN -> 7.2.3 #897
Conversation
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.fcrepo.kernel.impl.utils.impl; |
There was a problem hiding this comment.
Wasn't this file removed a while ago? Certainly the package name org.fcrepo.kernel.impl shouldn't be there.
- DistributedFixityCheck.java
| <persistence passivation="false"> | ||
| <file-store shared="false" | ||
| preload="false" | ||
| fetch-state="false" |
There was a problem hiding this comment.
Is there a reason this is different from fetchPersistentState in the old config? Reading the user guide explanation of the fetch-state option, it sounds like we want fetch-state=true: http://infinispan.org/docs/7.2.x/user_guide/user_guide.html#_configuration_2
- Change fetch-state to 'true'
| <transaction transaction-manager-lookup="org.infinispan.transaction.lookup.GenericTransactionManagerLookup" mode="NON_XA" locking="PESSIMISTIC"/> | ||
| <eviction max-entries="500" strategy="LIRS" thread-policy="DEFAULT"/> | ||
| <persistence> | ||
| <store:leveldb-store passivation="false" path="${fcrepo.ispn.repo.cache:target/repo}/data"> |
There was a problem hiding this comment.
I tried running the modeshape clustered config (config/clustered/repository.json) and got an error unless I removed the passivation attribute from this line and line 27.
There was a problem hiding this comment.
Out of curiosity, did you run it in a cluster or as a single instance?
There was a problem hiding this comment.
I tried to run a second node on the same machine, but it didn't work. I think it's worth testing clustering on two nodes before upgrading, so I can do that shortly and see if I can get it to work.
There was a problem hiding this comment.
As a side note, I also did some testing with running/populating a 4.3.0 version of Fedora, then starting up a Fedora with these upgraded configs on the same fcrepo.home... but more testing around backward/forward compatibility would be useful.
There was a problem hiding this comment.
I've tried running the clustered config on two machines, and I am getting an stacktrace and total failure on both machines. Here's a gist of my script (based on the system properties specified at https://wiki.duraspace.org/display/FEDORA4x/Deploying+a+Fedora+Cluster) and the error I'm getting:
There was a problem hiding this comment.
Is that with passivation= true or false?
There was a problem hiding this comment.
That's with the passivation attribute removed -- I get an error if it is present at all.
There was a problem hiding this comment.
Error:
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'modeshapeRepofactory': Invocation of init method failed; nested exception is org.fcrepo.kernel.api.exception.RepositoryRuntimeException: org.infinispan.commons.CacheConfigurationException: javax.xml.stream.XMLStreamException: ParseError at [row,col]:[14,100]|Message: Unexpected attribute 'passivation' encountered
|
This work is proceeding on the following branch ('modeshape-4.4.0'): ...and associated PR: |
Resolves: https://jira.duraspace.org/browse/FCREPO-1581