Hide minimap if it has been disabled by server

est31 · est31 · commit 0903190ba2ed · 2015-09-01T19:00:33.000+02:00
diff --git a/src/client.cpp b/src/client.cpp
@@ -228,6 +228,7 @@ Client::Client(
 	m_particle_manager(&m_env),
 	m_con(PROTOCOL_ID, 512, CONNECTION_TIMEOUT, ipv6, this),
 	m_device(device),
+	m_minimap_disabled_by_server(false),
 	m_server_ser_ver(SER_FMT_VER_INVALID),
 	m_proto_ver(0),
 	m_playeritem(0),
diff --git a/src/client.h b/src/client.h
@@ -510,6 +510,9 @@ class Client : public con::PeerHandler, public InventoryManager, public IGameDef
 	Mapper* getMapper ()
 	{ return m_mapper; }
 
+	bool isMinimapDisabledByServer()
+	{ return m_minimap_disabled_by_server; }
+
 	// IGameDef interface
 	virtual IItemDefManager* getItemDefManager();
 	virtual INodeDefManager* getNodeDefManager();
@@ -590,6 +593,7 @@ class Client : public con::PeerHandler, public InventoryManager, public IGameDef
 	con::Connection m_con;
 	IrrlichtDevice *m_device;
 	Mapper *m_mapper;
+	bool m_minimap_disabled_by_server;
 	// Server serialization version
 	u8 m_server_ser_ver;
 
diff --git a/src/game.cpp b/src/game.cpp
@@ -1857,6 +1857,9 @@ void Game::run()
 		updateFrame(highlight_boxes, &graph, &stats, &runData, dtime,
 				flags, cam_view);
 		updateProfilerGraphs(&graph);
+
+		// Update if minimap has been disabled by the server
+		flags.show_minimap &= !client->isMinimapDisabledByServer();
 	}
 }
 
diff --git a/src/hud.h b/src/hud.h
@@ -33,8 +33,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #define HUD_CORNER_CENTER 2
 
 // Note that these visibility flags do not determine if the hud items are
-// actually drawn, but rather, allows the item to be drawn should the rest of
-// the game state permit it.
+// actually drawn, but rather, whether to draw the item should the rest
+// of the game state permit it.
 #define HUD_FLAG_HOTBAR_VISIBLE    (1 << 0)
 #define HUD_FLAG_HEALTHBAR_VISIBLE (1 << 1)
 #define HUD_FLAG_CROSSHAIR_VISIBLE (1 << 2)
diff --git a/src/network/clientpackethandler.cpp b/src/network/clientpackethandler.cpp
@@ -24,6 +24,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "log.h"
 #include "map.h"
 #include "mapsector.h"
+#include "minimap.h"
 #include "nodedef.h"
 #include "serialization.h"
 #include "server.h"
@@ -1094,8 +1095,19 @@ void Client::handleCommand_HudSetFlags(NetworkPacket* pkt)
 	Player *player = m_env.getLocalPlayer();
 	assert(player != NULL);
 
+	bool was_minimap_visible = player->hud_flags & HUD_FLAG_MINIMAP_VISIBLE;
+
 	player->hud_flags &= ~mask;
 	player->hud_flags |= flags;
+
+	m_minimap_disabled_by_server = !(player->hud_flags & HUD_FLAG_MINIMAP_VISIBLE);
+
+	// Hide minimap if it has been disabled by the server
+	if (m_minimap_disabled_by_server && was_minimap_visible) {
+		// defers a minimap update, therefore only call it if really
+		// needed, by checking that minimap was visible before
+		m_mapper->setMinimapMode(MINIMAP_MODE_OFF);
+	}
 }
 
 void Client::handleCommand_HudSetParam(NetworkPacket* pkt)

Original file line number	Diff line number	Diff line change
`@@ -1857,6 +1857,9 @@ void Game::run()`
`1857`	`1857`	`updateFrame(highlight_boxes, &graph, &stats, &runData, dtime,`
`1858`	`1858`	`flags, cam_view);`
`1859`	`1859`	`updateProfilerGraphs(&graph);`
	`1860`	`+`
	`1861`	`+ // Update if minimap has been disabled by the server`
	`1862`	`+ flags.show_minimap &= !client->isMinimapDisabledByServer();`
`1860`	`1863`	`}`
`1861`	`1864`	`}`
`1862`	`1865`