[Truffle] add app/gem runner #3298

pitr-ch · 2015-08-31T20:58:05Z

How to try with activesupport:

install the gem
truffle --help to see the help
truffle --verbose setup (uses default bundled activesupport configuration) and sets the environment
truffle -v run test/core_ext/integer_ext_test.rb

We can add config files for libraries we test, plus we get the same environment locally when testing.

The bad path of the bundle issue is solved by symlink, https://github.com/jruby/jruby/pull/3298/files#diff-ebd53ce24fc30c47574135956e30702cR229.

chrisseaton · 2015-08-31T23:09:13Z

This looks like really good work and should be a great step forward in testing gems.

I can't figure out exactly how I'm supposed to use it though. How do I install the gem? Using my dev version of JRuby? How would it get onto my path?

I tried a couple of commands like this (without installing) and it didn't work:

chrisseaton@Chriss-MBP:~/Documents/ruby/psd.rb [master] $ ../jruby/bin/jruby ../jruby/tool/truffle/jruby_truffle_runner/bin/truffle --help
NameError: undefined local variable or method `help' for JRubyTruffleRunner:Class
                 method_missing at org/jruby/RubyBasicObject.java:1592
    block in JRubyTruffleRunner at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:25
                           call at org/jruby/RubyProc.java:308
  block in build_option_parsers at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:139
                           call at org/jruby/RubyProc.java:308
        block in parse_in_order at /Users/chrisseaton/Documents/ruby/jruby/lib/ruby/stdlib/optparse.rb:1396
                          catch at org/jruby/RubyKernel.java:1098
                 parse_in_order at /Users/chrisseaton/Documents/ruby/jruby/lib/ruby/stdlib/optparse.rb:1383
                         order! at /Users/chrisseaton/Documents/ruby/jruby/lib/ruby/stdlib/optparse.rb:1377
                          order at /Users/chrisseaton/Documents/ruby/jruby/lib/ruby/stdlib/optparse.rb:1369
                     initialize at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:107
                          <top> at ../jruby/tool/truffle/jruby_truffle_runner/bin/truffle:4
chrisseaton@Chriss-MBP:~/Documents/ruby/psd.rb [master] $ ../jruby/bin/jruby ../jruby/tool/truffle/jruby_truffle_runner/bin/truffle setup
/Users/chrisseaton/.rbenv/shims/bundle
No value provided for option '--without'
RuntimeError: command failed
       execute_cmd at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:268
  subcommand_setup at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:227
        initialize at /Users/chrisseaton/Documents/ruby/jruby/tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb:119
             <top> at ../jruby/tool/truffle/jruby_truffle_runner/bin/truffle:4

Could you post a complete example of use for Active Support?

chrisseaton · 2015-08-31T23:09:58Z

tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb

@@ -0,0 +1,270 @@
+require 'optparse'


Anything more substantial than a simple configuration file must begin with our standard copyright header - so the JRuby people are clear what we're putting into their repository if nothing else.

nirvdrum · 2015-09-01T00:50:39Z

tool/truffle/jruby_truffle_runner/jruby_truffle_runner.gemspec

+  s.platform    = Gem::Platform::RUBY
+  s.authors     = ['Petr Chalupa']
+  s.email       = ['git@pitr.ch']
+  s.homepage    = 'http://github.com/jruby/jruby'


May as well make this 'https' and avoid the redirect.

pitr-ch · 2015-09-01T06:26:32Z

Ah sorry, last minute changes strike again :(. --help option is broken, if you run just truffle without the -h option it will print help, it goes through different path. I'll fix rest in few hours.

pitr-ch · 2015-09-01T09:16:54Z

To run the executable, I either do ruby ../../jruby/tool/truffle/jruby_truffle_runner/bin/truffle --help or I install the gem from my JRuby repo (it'll be on rubygems later):

cd tool/truffle/jruby_truffle_runner
gem build jruby_truffle_runner.gemspec
gem install jruby_truffle_runner-0.0.1.gem
cd ../../../../rails/activesupport
then truffle --help should work

pitr-ch · 2015-09-01T09:20:52Z

Regarding usage for activesupport:

clone rails
cd rails/activesupport
install jruby_truffle_runner with a Ruby implementation (MRI or JRuby, for this case it worked both for me)
run truffle setup
run e.g. truffle run -- -I test test/core_ext/integer_ext_test.rb (assumes jruby on path ../../jruby/bin/ruby, can be changed in .truffle.yaml after setup step)

eregon · 2015-09-01T09:47:53Z

tool/truffle/jruby_truffle_runner/lib/jruby_truffle_runner.rb

+            test:       ['-t', '--test', 'Do not use Truffle use plain JRuby', assign_new_value, false],
+            debug:      ['-d', '--debug', 'JVM remote debugging', assign_new_value, false],
+            require:    ['-r', '--require FILE', 'Files to require, same as Ruby\'s -r', add_to_array, []],
+            load_path:  ['-l', '--load-path LOAD_PATH', 'Paths to add to load path, same as Ruby\'s -I', add_to_array, []],


can the shorthand be -I as well?

Yeah probably better.

eregon · 2015-09-01T09:57:42Z

Looks great, and it also raises the question what launcher do we want for testing/user/dev and I think it make sense to have sth slightly different for some of them.

eregon · 2015-09-01T10:04:35Z

tool/truffle/jruby_truffle_runner/bin/truffle

+#!/usr/bin/env ruby
+
+require_relative '../lib/jruby_truffle_runner.rb'
+JRubyTruffleRunner.new


This is not executable by default, can you chmod and commit that?

It should be renamed I think to match with the gem name.

done;

I am not sure, jruby_truffle_runner executable is quite long :/

pitr-ch · 2015-09-01T12:19:42Z

TODO:

rename truffle executable to jruby+truffle

chrisseaton · 2015-09-01T15:31:38Z

Can we merge this and then keep working on master? It's already very useful.

pitr-ch · 2015-09-01T15:41:44Z

Please check the last commit if you agree with the new names. After that we can merge.

chrisseaton · 2015-09-01T15:44:50Z

Looks good to me.

pitr-ch added the truffle label Aug 31, 2015

pitr-ch self-assigned this Aug 31, 2015

pitr-ch added this to the truffle-dev milestone Aug 31, 2015

pitr-ch force-pushed the master branch from 1b880b9 to 99fd7b6 Compare August 31, 2015 21:00

chrisseaton reviewed Aug 31, 2015
View reviewed changes

chrisseaton mentioned this pull request Aug 31, 2015

[Truffle] Shim to make it easier to use bundler. #3297

Closed

nirvdrum reviewed Sep 1, 2015
View reviewed changes

pitr-ch force-pushed the master branch 3 times, most recently from 57030a6 to a93c8ce Compare September 1, 2015 09:13

pitr-ch force-pushed the master branch from a93c8ce to 48f2a75 Compare September 1, 2015 09:25

eregon reviewed Sep 1, 2015
View reviewed changes

pitr-ch force-pushed the master branch 2 times, most recently from f6cf8f1 to b4de35f Compare September 1, 2015 12:05

pitr-ch added 2 commits September 1, 2015 17:57

[Truffle] add app/gem runner

421a008

[truffle] renamings in jruby+truffle runner gem

4a08cfe

pitr-ch force-pushed the master branch from a055114 to 4a08cfe Compare September 1, 2015 15:57

pitr-ch merged commit 4a08cfe into jruby:master Sep 1, 2015

enebo added this to the Non-Release milestone Dec 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GitHub Sponsors

[Truffle] add app/gem runner #3298

[Truffle] add app/gem runner #3298

pitr-ch commented Aug 31, 2015

chrisseaton commented Aug 31, 2015

chrisseaton Aug 31, 2015

pitr-ch Sep 1, 2015

nirvdrum Sep 1, 2015

pitr-ch commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

eregon Sep 1, 2015

pitr-ch Sep 1, 2015

eregon commented Sep 1, 2015

eregon Sep 1, 2015

eregon Sep 1, 2015

pitr-ch Sep 1, 2015

pitr-ch commented Sep 1, 2015

chrisseaton commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

chrisseaton commented Sep 1, 2015

[Truffle] add app/gem runner #3298

[Truffle] add app/gem runner #3298

Conversation

pitr-ch commented Aug 31, 2015

chrisseaton commented Aug 31, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pitr-ch commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eregon commented Sep 1, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pitr-ch commented Sep 1, 2015

chrisseaton commented Sep 1, 2015

pitr-ch commented Sep 1, 2015

chrisseaton commented Sep 1, 2015