Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beef up CI with optional requirements spelled out and apt installed #11

Merged
merged 1 commit into from Aug 29, 2015

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented Aug 29, 2015

No description provided.

@zmughal
Copy link
Member

zmughal commented Aug 29, 2015

Ah, yes, this is so that it will pull in the right modules later on when the PDL split is complete? I say this is worth it.

However, is there a way to say that those modules are optional in the Makefile.PL? I see that they are loaded at runtime and the rest of PDL-Stats will work without them installed.

mohawk2 added a commit that referenced this pull request Aug 29, 2015
Beef up CI with optional requirements spelled out and apt installed
@mohawk2 mohawk2 merged commit 58c48de into master Aug 29, 2015
@mohawk2 mohawk2 deleted the add-travis-deps branch August 29, 2015 03:08
zmughal added a commit that referenced this pull request Aug 31, 2015
PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite
causes new installs to fail.

This reverts part of the changes made in
<#11>.

Thanks to shawnlaffan++ for reporting this at
<#12>.
zmughal added a commit to PDLPorters/pdla-stats that referenced this pull request Aug 31, 2015
PDL::GSL::CDF is part of PDL-Stats, so having it as a prerequisite
causes new installs to fail.

This reverts part of the changes made in
<PDLPorters/PDL-Stats#11>.

Thanks to shawnlaffan++ for reporting this at
<PDLPorters/PDL-Stats#12>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants