Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark non-deterministic test TODO as fails on clang #10

Merged
merged 1 commit into from Aug 29, 2015

Conversation

mohawk2
Copy link
Member

@mohawk2 mohawk2 commented Aug 29, 2015

This seems fairly obvious until we can figure:

  • why it semi-consistently fails on clang and only there
  • a meaningful way to deterministically test a non-deterministic bit of code

I won't merge it without approval from either Zaki or Maggie.

@zmughal
Copy link
Member

zmughal commented Aug 29, 2015

This seems sensible for now. Since we still have #7 open, it will be there to remind us without annoyingly failing the whole build.

mohawk2 added a commit that referenced this pull request Aug 29, 2015
Mark non-deterministic test TODO as fails on clang
@mohawk2 mohawk2 merged commit 166b1e2 into master Aug 29, 2015
@mohawk2 mohawk2 deleted the todo-nondeterministic branch August 29, 2015 01:54
@maggiexyz
Copy link
Contributor

Thanks! I'll try to update the test again in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants