Implement an EVERYONE principal in WebACAuthorizationDelegate. #11
Conversation
peichman-umd
commented
Sep 1, 2015
peichman-umd
commented
- Name of the principal is the string value of the URI for foaf:Agent
- Name of the principal is the string value of the URI for foaf:Agent
| /** | ||
| * FOAF Agent | ||
| */ | ||
| public static final String FOAF_AGENT_VALUE = "http://xmlns.com/foaf/0.1/Agent"; |
There was a problem hiding this comment.
To make foaf more reusable, maybe you can use the pattern established above of defining the foaf namespace, then your FOAF_AGENT_VALUE can append to the namespace.
There was a problem hiding this comment.
That would be simple enough to add, though do we foresee using more FOAF properties or classes in the WebAC auth module? The YAGNI principle would pull in the direction of leaving it as-is until we need to add the next FOAF-namespaced constant.
There was a problem hiding this comment.
For my money, YAGNI is really about functionality. This is about code sanitation. A separate namespace constant is easier to read and understand.
There was a problem hiding this comment.
Additionally, foaf:member is expected for the acl:agentClass scenario.
https://www.w3.org/wiki/WebAccessControl
There was a problem hiding this comment.
Both good reasons. Stand by for updated PR.
|
Looks good, pending response to code review comment: |
|
👍 pending @awoods review comment. |
|
👍 |
|
Merged via 6a6b0ff |
