Skip to content
This repository has been archived by the owner on Jan 23, 2022. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdla-rest
base: 42c623545d82
Choose a base ref
...
head repository: PDLPorters/pdla-rest
compare: e8f31ef7850f
Choose a head ref
  • 1 commit
  • 53 files changed
  • 1 contributor

Commits on Aug 29, 2015

  1. test cleanup part 3

     - place all the eval { require ... } or plan skip_all in BEGIN {} blocks
    
     - using `Test::More` module (no hand-rolled TAP or `Test` module)
    
     - `use strict; use warnings` everywhere
    
     - remove use of `$a`, `$b` lexicals (reserved for `sort` function)
    
     - using `Test::Exception` (lives_ok, dies_ok, etc.) rather than the `eval { $code }; ok $@` combination
    
     - make each individual test run in its own scope
       e.g.
       ```perl
       {
     	my $test = ...
     	ok( ... );
       }
       {
     	my $test = ...
     	ok( ... );
       }
       ```
       This makes tests not dependent on previous code which means that they can be
       moved around without worrying about state. In the future, these should be setup
       as labelled subtests.
    
     - Using `all approx( ... )` instead of a custom `tapprox( ... )` in each file.
    
     - update TODO to remove the test refactoring items
    zmughal committed Aug 29, 2015
    Copy the full SHA
    e8f31ef View commit details
    Browse the repository at this point in the history