longlong double fix #145
Merged
longlong double fix #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, AUTOMATED_TESTING is not being set by Travis-CI |
This adds a union datatype to add 64bit integer support to the original PDL-2.x types which assumed that double was capable of holding all the "lesser" types. With the PDL_Anyval type, we can correctly handle 64bit integer datatypes and avoid errors and loss of precision due to conversions to or from PDL_Double. Thanks also to kmx for his contributions to finish the implementation.
Subtests to come. Contribution for others welcome.
wchristian
force-pushed
the
longlong-double-fix
branch
from
fd83457
to
c3583bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is for improving the 64-bit PDL support. This addresses issue #76, #37, SF#343.
All changes to this branch will automatically be tested. This makes using the squashed commits in #144 unnecessary.
CC: @devel-chm, @kmx