[Truffle] Shim to make it easier to use bundler. #3297
Closed
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (name.equals("RUBY_ENGINE") | ||
| && sourceSection.getSource().getPath().endsWith("bundler/setup.rb") | ||
| && sourceSection.getStartLine() == 3) { |
There was a problem hiding this comment.
This seems fragile, I would remove the line check.
|
Auto-loading of vendor/bundler/setup.rb seems bad, since many commands expect to run without the Bundler setup if it is not specified. |
|
I would suggest to wait with this PR until I submit mine PR with the gem. Both PRs are trying to solve similar thing. Let's discuss then what'll be the best approach. |
|
Yeah I forgot you were working on something similar. Better solutions welcome. |
|
Closing in favour of #3298. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nirvdrum had a script to run bundler with JRuby and then patch up the files it produced to let us use that. This shim simplifies that. For example you can now do:
This is something that we could start suggesting people try out on their own apps at some point soon.
I was also thinking about taking this a couple of steps further. Can we autodetect and run that
setup.rb? Can we provide a command bin/truffle-bundle that then lets you do just:@nirvdrum @pitr-ch @eregon please comment