Roles provider #28
Closed
Roles provider #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
n.b. this begins to supersede (but doesn't yet entirely replace) #8 |
This was referenced Sep 5, 2015
| * The RDF from each child resource is put into a WebACAuthorization object, and the | ||
| * full list is returned. | ||
| * | ||
| * @param session the jcr session used for locating the ACL resource |
|
@awoods I updated the PR with changes based on your suggestions |
|
Resolved with: 297cad3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement an AccessRolesProvider class.
This class is one of the missing links in our implementation. With it in place (and with the corresponding Spring configuration as shown in this PR), ACL resources are read, processed and user roles are added into the FAD.
This implementation has a complete unit testing framework, but it is a bit rough around the edges in two respects:
info:fedoraprefix into the class (it's not defined in the fedora kernel api). This is needed b/c triples pointing to repository resources use that prefix. Should that value be added to the kernel-api? Or should I be using a different translator when reading the Triples (I am currently usingDefaultIdentifierTranslator)?WebACAuthorizationImplclass out of the impl package. OSGi won't export those packages, and I thought that would be fine, since those aren't public-facing, but when deploying this with the class in.impl, I getClassNotFoundExceptions. Moving it into the.webacpackage fixes that. In this case, I'm somewhat inclined to turnWebACAuthorizationinto a fully-fledged class, rather than keeping it as an interface with a separate implementation.