Optimize nikola check #2027
Merged
Optimize nikola check #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def _call_nikola_list(site): | ||
| def _call_nikola_list(site, cache=None): | ||
| if cache is not None: | ||
| if 'files' in cache and 'deps' in cache: |
There was a problem hiding this comment.
Yes, because this checks if the values are in the cache. (Just checking one of the two is fine as well.)
There was a problem hiding this comment.
I would just trust that a correct cache is given, but okay.
There was a problem hiding this comment.
Somehow the cache must be filled when the values are not in there yet.
There was a problem hiding this comment.
I misunderstood the implementation slightly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
nikola checkis run with more than one flag, it runs_call_nikola_listseveral times to retrieve the same data. Adds a (optional) cache to avoid unnecessary calls.This also fixes failure return in
_execute().